Skip to content

Remove legacy Readers and Keepers #279

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
plafer opened this issue Dec 2, 2022 · 1 comment · Fixed by #456
Closed

Remove legacy Readers and Keepers #279

plafer opened this issue Dec 2, 2022 · 1 comment · Fixed by #456
Assignees
@plafer
Labels
O: maintainability Objective: cause to ease modification, fault corrections and improve code understanding
Milestone
v0.29.0

Comments

@plafer
Copy link
Contributor

plafer commented Dec 2, 2022

In favor of ValidationContext and ExecutionContext. Each handler's process() should be implemented as suggested here.

Follow-up to #257.
@Farhad-Shabani Farhad-Shabani added the O: maintainability Objective: cause to ease modification, fault corrections and improve code understanding label Jan 5, 2023
@plafer plafer mentioned this issue Jan 10, 2023
Closed
@plafer plafer mentioned this issue Jan 27, 2023
Merged
7 tasks
@github-project-automation github-project-automation bot moved this to 📥 To Do in ibc-rs Feb 2, 2023
@Farhad-Shabani Farhad-Shabani modified the milestones: ADR05, Support Anoma's onboarding efforts Feb 2, 2023
@Farhad-Shabani Farhad-Shabani moved this from 📥 To Do to 🏗️ In Progress in ibc-rs Feb 7, 2023
@plafer plafer mentioned this issue Feb 8, 2023
Closed
@Farhad-Shabani Farhad-Shabani removed this from the Support Anoma's onboarding efforts milestone Feb 8, 2023
@plafer plafer added this to the v0.29.0 milestone Feb 10, 2023
@plafer plafer self-assigned this Feb 10, 2023
This was referenced Feb 10, 2023
Closed
Closed
@plafer
Copy link
Contributor Author

plafer commented Feb 13, 2023

This includes renaming the temporary new_* functions (example).

@plafer plafer moved this from 🏗️ In Progress to 📥 To Do in ibc-rs Feb 14, 2023
This was referenced Feb 16, 2023
Merged
Closed
Merged
@github-project-automation github-project-automation bot moved this from 📥 To Do to ✅ Done in ibc-rs Feb 21, 2023
@plafer plafer mentioned this issue Feb 21, 2023
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@plafer plafer

Labels
O: maintainability Objective: cause to ease modification, fault corrections and improve code understanding
Projects
None yet
Milestone
v0.29.0
Development

Successfully merging a pull request may close this issue.

Remove Reader and Keeper API informalsystems/ibc-rs
2 participants
@plafer @Farhad-Shabani