Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove redundant #[test_log::test] attributes in test modules #948

Closed
Farhad-Shabani opened this issue Nov 6, 2023 · 0 comments · Fixed by #975
Closed

Remove redundant #[test_log::test] attributes in test modules #948

Farhad-Shabani opened this issue Nov 6, 2023 · 0 comments · Fixed by #975
Assignees
Labels
A: good-first-issue Admin: good for newcomers O: code-hygiene Objective: aims to improve code hygiene
Milestone

Comments

@Farhad-Shabani
Copy link
Member

Description

There are places in our test modules (e.g. here), we have used #[test_log::test] as the test attribute. However, neither the ibc-rs implementation nor its tests involve any logging or tracing. We should assess the codebase to identify and eliminate any instances where these attributes are redundant.

@Farhad-Shabani Farhad-Shabani added A: good-first-issue Admin: good for newcomers O: code-hygiene Objective: aims to improve code hygiene labels Nov 6, 2023
@github-project-automation github-project-automation bot moved this to 📥 To Do in ibc-rs Nov 6, 2023
@github-project-automation github-project-automation bot moved this from 📥 To Do to ✅ Done in ibc-rs Nov 22, 2023
@Farhad-Shabani Farhad-Shabani added this to the v0.48.0 milestone Nov 24, 2023
@Farhad-Shabani Farhad-Shabani self-assigned this Nov 24, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A: good-first-issue Admin: good for newcomers O: code-hygiene Objective: aims to improve code hygiene
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant