Add rspec-terraform, add unit tests, add rubocop.

Author: tobyclemson

.circleci/config.yml

@@ -70,14 +70,26 @@ commands:
       - run: ./scripts/ci/common/configure-git.sh
 
 jobs:
-  test:
+  build:
     <<: *defaults
     steps:
       - checkout
       - configure_tools
       - queue/until_front_of_line:
           consider-branch: false
-      - run: ./scripts/ci/steps/test.sh
+      - run: ./scripts/ci/steps/build.sh
+      - notify
+
+  test:
+    <<: *defaults
+    steps:
+      - checkout
+      - configure_tools
+      - run:
+          no_output_timeout: 30m
+          command: ./scripts/ci/steps/test.sh
+      - store_artifacts:
+          path: build/logs
       - notify
 
   prerelease:
@@ -108,26 +120,39 @@ workflows:
   version: 2
   pipeline:
     jobs:
-      - test:
+      - build:
+          <<: *only_main_and_dependabot
           <<: *slack_context
+      - test:
           <<: *only_main_and_dependabot
-      - merge_pull_request:
           <<: *slack_context
+          requires:
+            - build
+      - merge_pull_request:
           <<: *only_dependabot
+          <<: *slack_context
           requires:
             - test
       - prerelease:
-          <<: *slack_context
           <<: *only_main
+          <<: *slack_context
           requires:
             - test
+      - slack/on-hold:
+          <<: *only_main
+          <<: *slack_context
+          requires:
+            - prerelease
+          channel: release
+          template: SLACK_ON_HOLD_NOTIFICATION
       - hold:
           <<: *only_main
           type: approval
           requires:
             - prerelease
+            - slack/on-hold
       - release:
-          <<: *slack_context
           <<: *only_main
+          <<: *slack_context
           requires:
             - hold

.envrc

@@ -2,5 +2,5 @@
 
 PROJECT_DIR="$(pwd)"
 
-PATH_add ${PROJECT_DIR}
-PATH_add ${PROJECT_DIR}/vendor/terraform/bin
+PATH_add "${PROJECT_DIR}"
+PATH_add "${PROJECT_DIR}"/vendor/terraform/bin

.github/dependabot.yml

@@ -5,8 +5,6 @@ updates:
     directory: "/"
     schedule:
       interval: "daily"
-    ignore:
-      - dependency-name: "hashicorp/aws"
 
   - package-ecosystem: "bundler"
     directory: "/"

.gitignore

@@ -13,6 +13,7 @@ vendor/
 build/
 dist/
 .bundle
+.rakeTasks
 
 # OS
 .DS_Store
@@ -22,12 +23,13 @@ run/pids/
 run/logs/
 *.log
 .tmp
-.rakeTasks
 
 # RSpec
 .rspec_status
 
 # Terraform
+state/
 .terraform
+*.tfplan
 *.tfstate
 *.tfstate.backup

.rubocop.yml

@@ -0,0 +1,36 @@
+require:
+  - rubocop-rake
+  - rubocop-rspec
+
+AllCops:
+  NewCops: enable
+
+Layout/LineLength:
+  Max: 80
+
+Metrics/BlockLength:
+  AllowedMethods:
+    - describe
+    - context
+    - shared_examples
+    - it
+  Exclude:
+    - Rakefile
+
+Style/Documentation:
+  Enabled: false
+
+RSpec/ExampleLength:
+  Max: 40
+
+RSpec/DescribeClass:
+  Enabled: false
+
+RSpec/InstanceVariable:
+  Enabled: false
+
+RSpec/BeforeAfterAll:
+  Enabled: false
+
+RSpec/MultipleMemoizedHelpers:
+  Max: 10

CODE_OF_CONDUCT.md

@@ -5,9 +5,9 @@
 In the interest of fostering an open and welcoming environment, we as
 contributors and maintainers pledge to making participation in our project and
 our community a harassment-free experience for everyone, regardless of age, body
-size, disability, ethnicity, gender identity and expression, level of experience,
-nationality, personal appearance, race, religion, or sexual identity and
-orientation.
+size, disability, ethnicity, gender identity and expression, level of
+experience, nationality, personal appearance, race, religion, or sexual identity
+and orientation.
 
 ## Our Standards
 
@@ -23,7 +23,7 @@ include:
 Examples of unacceptable behavior by participants include:
 
 * The use of sexualized language or imagery and unwelcome sexual attention or
-advances
+  advances
 * Trolling, insulting/derogatory comments, and personal or political attacks
 * Public or private harassment
 * Publishing others' private information, such as a physical or electronic
@@ -58,17 +58,18 @@ Instances of abusive, harassing, or otherwise unacceptable behavior may be
 reported by contacting the project team at maintainers@infrablocks.io. All
 complaints will be reviewed and investigated and will result in a response that
 is deemed necessary and appropriate to the circumstances. The project team is
-obligated to maintain confidentiality with regard to the reporter of an incident.
-Further details of specific enforcement policies may be posted separately.
+obligated to maintain confidentiality with regard to the reporter of an
+incident. Further details of specific enforcement policies may be posted
+separately.
 
 Project maintainers who do not follow or enforce the Code of Conduct in good
 faith may face temporary or permanent repercussions as determined by other
 members of the project's leadership.
 
 ## Attribution
 
-This Code of Conduct is adapted from the [Contributor Covenant][homepage], version 1.4,
-available at [http://contributor-covenant.org/version/1/4][version]
+This Code of Conduct is adapted from the [Contributor Covenant][homepage],
+version 1.4, available at [http://contributor-covenant.org/version/1/4][version]
 
 [homepage]: http://contributor-covenant.org
 [version]: http://contributor-covenant.org/version/1/4/

Gemfile

@@ -1,16 +1,22 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 
 gem 'awspec'
 gem 'confidante'
 gem 'git'
-gem 'net-ssh'
 gem 'netaddr'
-gem 'nokogiri'
+gem 'net-ssh'
 gem 'rake'
 gem 'rake_circle_ci'
 gem 'rake_github'
 gem 'rake_gpg'
 gem 'rake_ssh'
 gem 'rake_terraform'
 gem 'rspec'
+gem 'rspec-terraform'
+gem 'rubocop'
+gem 'rubocop-rake'
+gem 'rubocop-rspec'
+gem 'rubyzip'
 gem 'semantic'