Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

PSP34 Transfer event parameter "from" is unnecessary #3

Open
Nradko opened this issue Feb 20, 2024 · 0 comments
Open

PSP34 Transfer event parameter "from" is unnecessary #3

Nradko opened this issue Feb 20, 2024 · 0 comments

Comments

@Nradko
Copy link

Nradko commented Feb 20, 2024

In PSP34 the Transfer event possesses field "from" that is unnecessary.

One can always deduce the previous owner of a token with an ID based on the previous Transfer event that contains the ID.
If such a previous event doesn't exist it means that the token hasn't been minted.

I would recommend changing the standard. Changes to events will not break the cross-contract calls. Also If one assumes the new standard in one's off-chain application the application will be compatible with the previous standard as long as one allows the field "from" to be undefined.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant