-
-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: support remote manifests #309
Conversation
Can you add tests? |
ok, i will try |
finished, please review |
Thanks! Please try not to update every changed file with your configured code style next time, though. |
Sorry, I'm not familiar with php-cs-fixer, can you tell me which command should I use? |
And did you forget to add a new config item in the config file? |
php-cs-fixer has no rules for this, but you changed whitespaces in a few places (there and there for instance). No big deal but annoying for maintainers.
No, the third parameter is the value returned if it doesn't exist in the config. I think this feature is quite niche, and since it isn't documented I didn't feel like it needed to have a default value in the configuration file. Feel free to PR though! |
I think it would be better to change the config key? |
Feel free to PR whatever you need as long as it makes sense and you provide an explanation for the change 👍 |
No description provided.