fixed solid reactivity

inokawa · Apr 3, 2024 · 3d8232c · 3d8232c
1 parent f43016a
commit 3d8232c
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/src/solid/RangedFor.tsx b/src/solid/RangedFor.tsx
@@ -9,6 +9,7 @@ import {
   untrack,
   JSX,
   Signal,
+  Accessor,
 } from "solid-js";
 import { ItemsRange } from "../core/types";
 
@@ -27,7 +28,7 @@ interface RenderedNode<T> {
 export const RangedFor = <T,>(props: {
   _each: T[];
   _range: ItemsRange;
-  _render: (data: T, index: number) => JSX.Element;
+  _render: (data: Accessor<T>, index: number) => JSX.Element;
 }): JSX.Element => {
   let prev = new Map<number, RenderedNode<T>>();
 
@@ -52,7 +53,7 @@ export const RangedFor = <T,>(props: {
             ? lookup._element
             : createRoot((dispose) => {
                 const data = createSignal(newData);
-                const result = props._render(data[0](), i);
+                const result = props._render(data[0], i);
                 current.set(i, {
                   _data: data,
                   _element: result,

diff --git a/src/solid/Virtualizer.tsx b/src/solid/Virtualizer.tsx
@@ -295,7 +295,7 @@ export const Virtualizer = <T,>(props: VirtualizerProps<T>): JSX.Element => {
               _resizer={resizer._observeItem}
               _offset={offset()}
               _hide={hide()}
-              _children={props.children(data, index)}
+              _children={props.children(data(), index)}
               _isHorizontal={horizontal}
             />
           );

diff --git a/src/solid/WindowVirtualizer.tsx b/src/solid/WindowVirtualizer.tsx
@@ -228,7 +228,7 @@ export const WindowVirtualizer = <T,>(
               _resizer={resizer._observeItem}
               _offset={offset()}
               _hide={hide()}
-              _children={props.children(data, index)}
+              _children={props.children(data(), index)}
               _isHorizontal={horizontal}
             />
           );