-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
bug(YouTube): Patching fails under certain conditions #2538
Comments
This is probably a bug on the patch side If a patch is missing a dependency, this issue can occur |
Mostly BytecodePatch is causing everything to fail. Here's my patchlog using revancify - |
I also have the same error. My cli command.
If I include 'Custom header for YouTube' for YouTube and 'Custom header for YouTube Music' for YouTube Music, it will set icon and also header with default value even I specify appIcon to another icon. If I don't include that patches, the icon patch will work as intended. |
the app still crashes with my patch selection on 19.16.39 (although all selected patches show succeeded and options.json is now being read) i tried with half of the patches and then the other half, but it was still crashing |
reflected in revanced-patches-5.1.1 |
Application
YouTube
Question description
cli - latest 5.0.1
patches - latest stable/dev
jdk - zulu 17
i use the following cli command to build
java -jar "revanced-cli-5.0.1.jar" patch -p "patches.rvp" --exclusive -e "Change share sheet" -e "Change start page" -e "Custom branding icon for YouTube" -e "Custom Shorts action buttons" -e "Description components" -e "Disable auto captions" -e "Disable haptic feedback" -e "Disable resuming Shorts on startup" -e "Disable splash animation" -e "Enable external browser" -e "Enable open links directly" -e "Force hide player buttons background" -e "Fullscreen components" -e "GmsCore support" -e "Hide Shorts dimming" -e "Hide action buttons" -e "Hide ads" -e "Hide comments components" -e "Hide feed components" -e "Hide feed flyout menu" -e "Hide layout components" -e "Hide player buttons" -e "Hide player flyout menu" -e "Hook download actions" -e "Navigation bar components" -e "Overlay buttons" -e "Player components" -e "Remove background playback restrictions" -e "Sanitize sharing links" -e "Seekbar components" -e "Shorts components" -e "SponsorBlock" -e "Swipe controls" -e "Theme" -e "Toolbar components" -e "Video playback" -e "Visual preferences icons for YouTube" --legacy-options="options.json" "youtube-v19.16.39.apk" -o "RVX.apk"
but most patches keep failing
patchlog.txt
also the options.json file isnt read (since custom icon patch succeeded but output apk has revancify icon instead of stock icon which i specified)
am i missing some requirement here? or my cli usage command is wrong? i cant find any solution in documentation.
Acknowledgements
The text was updated successfully, but these errors were encountered: