Skip to content

Commit 61f471c

Browse files
committed
[ETCM-842] Apply PR remarks
1 parent 041d147 commit 61f471c

File tree

3 files changed

+6
-10
lines changed

3 files changed

+6
-10
lines changed

Diff for: src/main/scala/io/iohk/ethereum/network/p2p/MessageDecoders.scala

+3-3
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ object NetworkMessageDecoder extends MessageDecoder {
2727
case Ping.code => payload.toPing
2828
case Pong.code => payload.toPong
2929
case Hello.code => payload.toHello
30-
case _ => throw new RuntimeException(s"Unknown message type: ${msgCode}")
30+
case _ => throw new RuntimeException(s"Unknown message type: $msgCode")
3131
}
3232

3333
}
@@ -51,7 +51,7 @@ object ETC64MessageDecoder extends MessageDecoder {
5151
case Codes.BlockBodiesCode => payload.toBlockBodies
5252
case Codes.BlockHashesFromNumberCode => payload.toBlockHashesFromNumber
5353
case Codes.SignedTransactionsCode => payload.toSignedTransactions
54-
case _ => throw new RuntimeException(s"Unknown message type: ${msgCode}")
54+
case _ => throw new RuntimeException(s"Unknown message type: $msgCode")
5555
}
5656
}
5757
}
@@ -75,7 +75,7 @@ object ETH63MessageDecoder extends MessageDecoder {
7575
case Codes.StatusCode => payload.toStatus
7676
case Codes.NewBlockCode => payload.toNewBlock
7777
case Codes.SignedTransactionsCode => payload.toSignedTransactions
78-
case _ => throw new RuntimeException(s"Unknown message type: ${msgCode}")
78+
case _ => throw new RuntimeException(s"Unknown message type: $msgCode")
7979
}
8080
}
8181
}

Diff for: src/main/scala/io/iohk/ethereum/nodebuilder/NodeBuilder.scala

-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ import io.iohk.ethereum.network.EtcPeerManagerActor.PeerInfo
2424
import io.iohk.ethereum.network.PeerManagerActor.PeerConfiguration
2525
import io.iohk.ethereum.network.discovery.{DiscoveryConfig, DiscoveryServiceBuilder, PeerDiscoveryManager}
2626
import io.iohk.ethereum.network.handshaker.{EtcHandshaker, EtcHandshakerConfiguration, Handshaker}
27-
import io.iohk.ethereum.network.p2p.{EthereumMessageDecoder, NetworkMessageDecoder}
2827
import io.iohk.ethereum.network.rlpx.AuthHandshaker
2928
import io.iohk.ethereum.network.{PeerManagerActor, ServerActor, _}
3029
import io.iohk.ethereum.ommers.OmmersPool

Diff for: src/test/scala/io/iohk/ethereum/network/p2p/messages/MessagesSerializationSpec.scala

+3-6
Original file line numberDiff line numberDiff line change
@@ -91,9 +91,9 @@ class MessagesSerializationSpec extends AnyWordSpec with ScalaCheckPropertyCheck
9191
}
9292
}
9393

94-
"support ETH61 messages as ETH63" when {
94+
"ETH63" when {
9595
val version = ProtocolVersions.ETH63
96-
"encoding and decoding NewBlockHashes" should {
96+
"encoding and decoding ETH61.NewBlockHashes" should {
9797
"throw for unsupported message version" in {
9898
val msg = ETH61.NewBlockHashes(Seq(ByteString("23"), ByteString("10"), ByteString("36")))
9999
assertThrows[RuntimeException] {
@@ -108,11 +108,8 @@ class MessagesSerializationSpec extends AnyWordSpec with ScalaCheckPropertyCheck
108108
verify(msg, (m: BlockHashesFromNumber) => m.toBytes, Codes.BlockHashesFromNumberCode, version)
109109
}
110110
}
111-
}
112111

113-
"support ETH62 messages as ETH63" when {
114-
val version = ProtocolVersions.ETH63
115-
"encoding and decoding NewBlockHashes" should {
112+
"encoding and decoding ETH62.NewBlockHashes" should {
116113
"return same result" in {
117114
val msg = ETH62.NewBlockHashes(Seq(BlockHash(ByteString("hash1"), 1), BlockHash(ByteString("hash2"), 2)))
118115
verify(msg, (m: ETH62.NewBlockHashes) => m.toBytes, Codes.NewBlockHashesCode, version)

0 commit comments

Comments
 (0)