Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Implement reactive_counts option to the filter_settings #188

Closed
Tracked by #6
gogonzo opened this issue Feb 3, 2023 · 0 comments · Fixed by #247
Closed
Tracked by #6

Implement reactive_counts option to the filter_settings #188

gogonzo opened this issue Feb 3, 2023 · 0 comments · Fixed by #247

Comments

@gogonzo
Copy link
Contributor

gogonzo commented Feb 3, 2023

Could be done after #187

In the filter_settings we want the option reactive_counts = character(1) to enable/disable recalculation of the count labels. In cases when datasets are big, we would like to avoid the situation where all active filters are recomputed based on the filtered-values. When reactive_counts = FALSE the count bars will show only raw-data-counts as we used to present before.

Make sure that when reactive_counts = "none" initializes FilterState with the x_reactive = reactive(NULL)

Note: reactive_counts should be a character describing type of counts. IN the near future we will think more about "hierarchical" reactive counts which are straightforward now to implement (on the server side).

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants