Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Need phantomjs tests #56

Open
ljharb opened this issue Sep 9, 2020 · 0 comments
Open

Need phantomjs tests #56

ljharb opened this issue Sep 9, 2020 · 0 comments

Comments

@ljharb
Copy link
Member

ljharb commented Sep 9, 2020

See enzymejs/enzyme#2439 - basically, in phantomjs, the Reflect.apply logic broke without 579179e.

To prevent this from happening again, we need to set up automated tests in phantomjs.

I've gotten both karma and testling to run locally; however, neither is producing the proper exit code to match the tests passing/failing. I've looked into karma-tape/karma-tape-reporter, as example.

I've also come up with an approach to ensure that phantomjs-prebuilt can live in package.json without breaking node 0.8's CI, by making a subpackage that adds it as an optional dep.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

1 participant