Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Paging in call logs breaks paging in phonebook #750

Closed
spalladino opened this issue Oct 11, 2016 · 3 comments
Closed

Paging in call logs breaks paging in phonebook #750

spalladino opened this issue Oct 11, 2016 · 3 comments
Assignees
Milestone

Comments

@spalladino
Copy link
Contributor

  1. Navigate to a project's phonebook
  2. Note that the pager (if there is more than a single page) correctly points to page 2 of the project's contacts by hovering on the next page button
  3. Navigate to call logs
  4. Move to the next page
  5. Go back to a phonebook
  6. Note that the pager's next page URL now points to the call log listings, thus breaking the phonebook's pager

screen shot 2016-10-11 at 11 26 35 am

Both call logs and the phonebook are implemented using the same paginate helper method, though the former uses listings and the latter does not. Could be caused by listings making use of a session parameter to store current listing information, and using it in the paginate helper?

@spalladino spalladino added the bug label Oct 11, 2016
@spalladino
Copy link
Contributor Author

cc @bcardiff

@bcardiff
Copy link
Contributor

@spalladino overriding #param_page in the listing https://github.com/manastech/listings/blob/master/lib/listings/base.rb#L31 can be a workaround for this issue. There might be more params that collide though.

@spalladino spalladino self-assigned this Oct 20, 2016
@spalladino spalladino added this to the Release 2.8 milestone Oct 20, 2016
@mmuller
Copy link

mmuller commented Nov 7, 2016

Ok in version 3.0-pre1

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

3 participants