Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

if self.progressbar and tqdm is None set progressbar to False #38

Closed
raybellwaves opened this issue Jun 9, 2021 · 2 comments · Fixed by #41
Closed

if self.progressbar and tqdm is None set progressbar to False #38

raybellwaves opened this issue Jun 9, 2021 · 2 comments · Fixed by #41

Comments

@raybellwaves
Copy link
Contributor

https://github.com/NCAR/intake-thredds/blob/54f1a8d83588b460f35dd99a3d4597176571e0fd/intake_thredds/source.py#L86

Rather than raising a ValueError you could just say tqdm not installed setting progressbar=False
@aaronspring
Copy link
Collaborator

you are welcome to implement this

@andersy005 andersy005 mentioned this issue Jun 9, 2021
Closed
@raybellwaves
Copy link
Contributor Author

Now I think about this how about just make tqdm as a requirement?

It's not uncommon as a requirement mamba repoquery whoneeds tqdm -c conda-forge.

Can help slim the code base here.

@raybellwaves raybellwaves mentioned this issue Jun 14, 2021
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add tqdm to requirements raybellwaves/intake-thredds
2 participants
@aaronspring @raybellwaves