From 29a9acfda72bab69e646e5e50a8df5e0876cba90 Mon Sep 17 00:00:00 2001 From: jcesarmobile Date: Fri, 10 Apr 2020 11:34:21 +0200 Subject: [PATCH] fix(cli): Warn if core version doesn't match platform version (#2736) --- cli/src/common.ts | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/cli/src/common.ts b/cli/src/common.ts index a6c84b0d5..63c50eacf 100644 --- a/cli/src/common.ts +++ b/cli/src/common.ts @@ -405,13 +405,12 @@ export async function getPlatformVersion(config: Config, platform: string): Prom } export async function checkPlatformVersions(config: Config, platform: string) { - const cliVersion = await getCLIVersion(config); + const coreVersion = await getCoreVersion(config); const platformVersion = await getPlatformVersion(config, platform); - - if (semver.gt(cliVersion, platformVersion)) { + if (semver.diff(coreVersion, platformVersion) === 'minor' || semver.diff(coreVersion, platformVersion) === 'major') { log('\n'); - logInfo(`Your @capacitor/cli version is greater than @capacitor/${platform} version`); - log(`Consider updating to matching version ${chalk`{bold npm install @capacitor/${platform}@${cliVersion}}`}`); + logWarn(`Your @capacitor/core version doesn't match your @capacitor/${platform} version`); + log(`Consider updating to matching version ${chalk`{bold npm install @capacitor/core@${platformVersion}}`}`); } }