Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(toast): unify duration across platforms #2340

Merged
merged 4 commits into from
Feb 5, 2020
Merged

fix(toast): unify duration across platforms #2340

merged 4 commits into from
Feb 5, 2020

Conversation

pwespi
Copy link
Contributor

@pwespi pwespi commented Jan 15, 2020

@jcesarmobile jcesarmobile added this to the 2.0.0 milestone Jan 29, 2020
jcesarmobile
jcesarmobile requested changes Feb 4, 2020
View reviewed changes
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Can you fix the merge conflicts?

@pwespi
Copy link
Contributor Author

pwespi commented Feb 4, 2020

@jcesarmobile done

@pwespi pwespi requested a review from jcesarmobile February 4, 2020 20:46
jcesarmobile
jcesarmobile approved these changes Feb 5, 2020
View reviewed changes
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, good catch on the duration not working.

@jcesarmobile jcesarmobile changed the title fix(toast): fix and unify toast duration values and default across platforms fix(toast): unify toast duration across platforms Feb 5, 2020
@jcesarmobile jcesarmobile changed the title fix(toast): unify toast duration across platforms fix(toast): unify duration across platforms Feb 5, 2020
@jcesarmobile jcesarmobile merged commit 717dd0a into ionic-team:master Feb 5, 2020
chrisweight added a commit to chrisweight/capacitor that referenced this pull request Feb 17, 2020
@chrisweight
Merge remote-tracking branch 'upstream/master'
de72bcd 
* upstream/master: (50 commits)
  feat(Device): Add getBatteryInfo function (ionic-team#2435)
  fix(doctor): add electron checks (ionic-team#2434)
  chore(android): target SDK version 29 (ionic-team#2433)
  feat(android): update gradle and dependencies (ionic-team#2431)
  fix(ios): Make Clipboard plugin return errors (ionic-team#2430)
  feat(android): Handle onDestroy lifecycle event in plugins (ionic-team#2421)
  docs(ce-plugins): Remove or replace deprecated plugins (ionic-team#2419)
  feat(ios): change native location accuracy values (ionic-team#2420)
  docs(ce-guides): Remove dead link (ionic-team#2418)
  docs(network): Remove example guide because of dead link (ionic-team#2417)
  feat(electron): Remove injectCapacitor function (ionic-team#2415)
  fix(android): plugin retained events not being retained if listeners were empty (ionic-team#2408)
  chore(android): remove unused launch_splash.xml (ionic-team#2411)
  feat(Filesystem): Remove createIntermediateDirectories from MkdirOptions (ionic-team#2410)
  feat(android): use Fused Location Provider on Geolocation plugin (ionic-team#2409)
  fix(toast): unify duration across platforms (ionic-team#2340)
  feat(PushNotifications): Make register method return if permission was granted (ionic-team#2324)
  chore(circleci): update Xcode and remove install-cocoapods job (ionic-team#2402)
  chore(cli): fix tests for newer node versions (ionic-team#2403)
  fix(android): return original camera image if edition was canceled (ionic-team#2358)
  ...
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jcesarmobile jcesarmobile jcesarmobile approved these changes

Assignees
No one assigned
Labels
priority: high
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

bug: toast duration inconsistencies
2 participants
@pwespi @jcesarmobile