Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(electron): Provide app version in Device.getInfo() #2521

Merged
merged 1 commit into from
Mar 12, 2020
Merged

fix(electron): Provide app version in Device.getInfo() #2521

merged 1 commit into from
Mar 12, 2020

Conversation

ivannkf
Copy link
Contributor

@ivannkf ivannkf commented Mar 4, 2020

Added the missing app version in electron

jcesarmobile
jcesarmobile approved these changes Mar 12, 2020
View reviewed changes
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks!

@jcesarmobile jcesarmobile changed the title Add app version in electron fix(electron): Provide app version in Device.getInfo() Mar 12, 2020
@jcesarmobile jcesarmobile merged commit 0998ae8 into ionic-team:master Mar 12, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jcesarmobile jcesarmobile jcesarmobile approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivannkf @jcesarmobile