Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

docs(site): Add target blank to external links in site header #2543

Merged
merged 1 commit into from
Mar 17, 2020
Merged

docs(site): Add target blank to external links in site header #2543

merged 1 commit into from
Mar 17, 2020

Conversation

arnauddrain
Copy link
Contributor

The GitHub link has a "targetblank" icon but the link hasn't. Same for the socials links, they have a target blank in the footer but not in the header.

@jcesarmobile jcesarmobile changed the title Add tarket blank to external links in site header docs(site): Add target blank to external links in site header Mar 17, 2020
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks!

@jcesarmobile jcesarmobile merged commit f6c2288 into ionic-team:master Mar 17, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants