fix(web): Gracefully degrade Proxy usage to fix IE11 #2759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurentgoudet
commented
Apr 14, 2020
core/package.json
Outdated
| @@ -59,7 +59,8 @@ | |||
| }, | |||
| "testMatch": [ | |||
| "**/__test__/*.(ts|tsx|js)" | |||
| ] | |||
| ], | |||
| "testURL": "http://localhost/" | |||
There was a problem hiding this comment.
FYI I had to add that to make the tests work as jest throws SecurityError: localStorage is not available for opaque origins otherwise, the reason being that testURL defaults to about:blank in v0.22 whereas it has been fixed to http://localhost/ in the latest version.
This can be removed once jest has been upgraded, but this was beyond the scope of the PR.
|
Thanks @laurentgoudet, looks good to me. Curious what @jcesarmobile thinks |
jcesarmobile
requested changes
Apr 29, 2020
laurentgoudet
force-pushed
the
fix-ie11-proxy-syntax-error
branch
from
3c13b58 to
6b58239
Compare
Done |
jcesarmobile
approved these changes
Apr 29, 2020
4 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #456. This guards the
Proxyusage is order to ensures that loading Capacitor does not throw a Syntax Error in IE11 and other older browser engines.