Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(ios): show toast when loading url in debug mode #2871

Merged
merged 8 commits into from
Jun 8, 2020
Merged

feat(ios): show toast when loading url in debug mode #2871

merged 8 commits into from
Jun 8, 2020

Conversation

Heerschop
Copy link
Contributor

Added a Using app server toast, for iOS when running an app in debug mode on a custom server.url. This is functionally the same as the Android toast.

Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a Toast plugin with very similar code, so maybe you can reuse and abstract it's code in a way that allows other native classes to show toasts instead of adding all this similar code in the CAPBridgeViewController

@Heerschop
Copy link
Contributor Author

I was afraid you would mention something like this :-) and I agree. I tried doing it that way, but I don't know anything about swift, this is basically the first time I'm using it.

When I tried I was unable to import a class from a different file. I can make the 'showToast' function nicer like you suggested and make it public.

@Heerschop Heerschop requested a review from jcesarmobile May 13, 2020 04:21
@jcesarmobile jcesarmobile changed the title Using app server ios toast feat(ios): show toast when loading url in debug mode Jun 8, 2020
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made a few changes like using showToast without being a static method and some other minor changes.

Thanks for the PR!

@jcesarmobile jcesarmobile merged commit 171870b into ionic-team:master Jun 8, 2020
@Heerschop
Copy link
Contributor Author

Really happy with this update thank you very much.

@Heerschop Heerschop deleted the using-app-server-ios-toast branch June 9, 2020 03:58
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants