-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat(ios): show toast when loading url in debug mode #2871
feat(ios): show toast when loading url in debug mode #2871
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a Toast plugin with very similar code, so maybe you can reuse and abstract it's code in a way that allows other native classes to show toasts instead of adding all this similar code in the CAPBridgeViewController
I was afraid you would mention something like this :-) and I agree. I tried doing it that way, but I don't know anything about swift, this is basically the first time I'm using it. When I tried I was unable to import a class from a different file. I can make the 'showToast' function nicer like you suggested and make it public. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made a few changes like using showToast without being a static method and some other minor changes.
Thanks for the PR!
Really happy with this update thank you very much. |
Added a Using app server toast, for iOS when running an app in debug mode on a custom
server.url
. This is functionally the same as the Android toast.