Add tests for PluginMethodHandler #3153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imjacobclark
force-pushed
the
test-plugin-method-handler
branch
from
032cc44 to
7a98d68
Compare
|
@imjacobclark Just as an FYI we're about to perform some heavy refactors of the native platforms to accomplish a few goals for Capacitor 3. These added tests are appreciated, but they may be removed in the weeks/months to come. I just wanted to make you aware of the situation before too much time is invested. We have more resources for Capacitor now, and new additions will come with unit tests. |
imhoffd
reviewed
Jun 25, 2020
|
Thank you! 🍻 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds test coverage to the PluginHandlerMethod class... more of these to come!