Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(cli): Avoid duplicate usesCleartextTraffic attribute #3245

Merged
merged 1 commit into from
Jul 13, 2020

Conversation

jcesarmobile
Copy link
Member

If using cordova-plugin-cleartext, the usesCleartextTraffic gets added twice, and doesn't have a whitespace between them, so fails to build.

This PR adds the whitespace and also prevent the second usesCleartextTraffic attribute being added if some plugin already added it.

@jcesarmobile jcesarmobile requested a review from imhoffd July 13, 2020 13:16
@jcesarmobile jcesarmobile merged commit 861874f into ionic-team:master Jul 13, 2020
@jcesarmobile jcesarmobile deleted the duplicated-cleartext branch July 13, 2020 16:16
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants