Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Ensure the web asset dir is only checked during copy #4029

Closed
imhoffd opened this issue Jan 7, 2021 · 2 comments
Closed

Ensure the web asset dir is only checked during copy #4029

imhoffd opened this issue Jan 7, 2021 · 2 comments
Assignees
Labels
bug cli dx improves developer experience
Milestone

Comments

@imhoffd
Copy link
Contributor

imhoffd commented Jan 7, 2021

The existence of the web asset directory should only be checked when running copy/sync, not during add or other commands.

The current behavior can lead to this error:

❯ npx cap add
[error] Could not find the web assets directory: /Users/dan/git/capacitor-testapp/build.
        Please create it and make sure it has an index.html file. You can change the path of this directory in
        capacitor.config.ts (webDir option). You may need to compile the web assets for your app (typically npm run
        build).
        More info: https://capacitorjs.com/docs/v3/basics/workflow#sync-your-project

Also see ionic-team/ionic-cli#4510

@imhoffd imhoffd added bug cli dx improves developer experience labels Jan 7, 2021
@imhoffd imhoffd added this to the 3.0.0-rc milestone Jan 7, 2021
@imhoffd imhoffd self-assigned this Feb 16, 2021
@imhoffd
Copy link
Contributor Author

imhoffd commented Feb 16, 2021

We're good. 💯

Related PR: #4215

@imhoffd imhoffd closed this as completed Feb 16, 2021
@ionitron-bot
Copy link

ionitron-bot bot commented Nov 11, 2022

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Capacitor, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Nov 11, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
bug cli dx improves developer experience
Projects
None yet
Development

No branches or pull requests

1 participant