Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(cli): Remove buildOptions from platform capacitor.config.json #6292

Merged
merged 2 commits into from
Feb 15, 2023
Merged

fix(cli): Remove buildOptions from platform capacitor.config.json #6292

merged 2 commits into from
Feb 15, 2023

Conversation

jcesarmobile
Copy link
Member

all extConfig properties are read only, so typescript doesn't allow to delete buildOptions directly
by casting to any, we can easily remove buildOptions from extConfig.android before writing the platforms capacitor.config.json file

close #6246

@jcesarmobile jcesarmobile merged commit acddcd9 into main Feb 15, 2023
@jcesarmobile jcesarmobile deleted the remove-buildOptions branch February 15, 2023 15:41
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@IT-MikeS IT-MikeS IT-MikeS approved these changes

@giralte-ionic giralte-ionic giralte-ionic approved these changes

@ItsChaceD ItsChaceD Awaiting requested review from ItsChaceD

@theproducer theproducer Awaiting requested review from theproducer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: Capacitor exposes our keystore password to final release bundle
3 participants
@jcesarmobile @IT-MikeS @giralte-ionic