Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat(doc): add Web Types #1301

Merged
merged 3 commits into from
Nov 15, 2023
Merged

feat(doc): add Web Types #1301

merged 3 commits into from
Nov 15, 2023

Conversation

piotrtomiak
Copy link
Contributor

@piotrtomiak piotrtomiak commented Nov 6, 2023 •
edited by liamdebeasi
Loading

resolves #1300

@mapsandapps mapsandapps removed their request for review November 6, 2023 14:29
@liamdebeasi
Copy link
Contributor

Hey there! Thanks for making this PR. Could you please describe what this feature does?

@piotrtomiak
Copy link
Contributor Author

Hmm. I've created an issue - #1300, but it didn't link through the commit message. Details there.

@liamdebeasi
Copy link
Contributor

Oh right, you added support for this to Ionic Vue as well. I knew your profile picture looked familiar 😄

I'll have someone from the team review this week.

@liamdebeasi liamdebeasi changed the title feat(doc): add Web Types (#1300) feat(doc): add Web Types Nov 15, 2023
@liamdebeasi liamdebeasi changed the base branch from main to feature-7.3.0 November 15, 2023 16:46
@liamdebeasi liamdebeasi self-requested a review November 15, 2023 16:46
liamdebeasi
liamdebeasi approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@liamdebeasi liamdebeasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@liamdebeasi liamdebeasi merged commit f946a3e into ionic-team:feature-7.3.0 Nov 15, 2023
@liamdebeasi
Copy link
Contributor

Merged. Thank you for contributing this!

@liamdebeasi liamdebeasi mentioned this pull request Nov 15, 2023
Closed
@piotrtomiak
Copy link
Contributor Author

Thanks!

@phucle1010 phucle1010 mentioned this pull request May 24, 2024
Open
This was referenced Sep 12, 2024
Open
Open
@ejreyes-ugr ejreyes-ugr mentioned this pull request Sep 15, 2024
Open
@AnirudhJalagam AnirudhJalagam mentioned this pull request Oct 4, 2024
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@liamdebeasi liamdebeasi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: add Web Types
2 participants
@piotrtomiak @liamdebeasi