user removed during a sync workflow

[laurentsenta]

@dhuseby was added on April 5:
libp2p/github-mgmt#142

There was a sync during April 9:
https://github.com/libp2p/github-mgmt/actions/runs/4647735487/jobs/8224899783

Sync worked as expected,

github_membership.this["dhuseby"]: Refreshing state... [id=libp2p:dhuseby]

The next Sync workflow, April 16, he was removed:
commit: libp2p/github-mgmt@5a03b43
job: https://github.com/libp2p/github-mgmt/actions/runs/4710428931/jobs/8354060171

Listing w3dt-stewards members...
/home/runner/work/_temp/b4821f41-f7b7-431d-a8b8-cfd55943072d/terraform state rm -lock=true github_membership.this["dhuseby"]
Removed github_membership.this["dhuseby"]
Successfully removed 1 resource instance(s).
/home/runner/work/_temp/b4821f41-f7b7-431d-a8b8-cfd55943072d/terraform state rm -lock=true github_team_membership.this["w3dt-stewards:dhuseby"]
Removed github_team_membership.this["w3dt-stewards:dhuseby"]
Successfully removed 1 resource instance(s).
Releasing state lock. This may take a few moments...

(manual fix on may 1st: libp2p/github-mgmt#145)

There were two merges in between and a few manual runs for workflows / error fixes.

[galargh]

It's because an invitation to the org wasn't accepted. If the invitation is pending, we leave memberships intact. Once it expires, the sync clears it from YAML because the user is not in fact a member of the org. Also, if we didn't clear it, there would be no way to resend the invitation through GitHub Management.

It'd be nice to have a info that after being added as a member you still have to accept an email invitation. libp2p/github-mgmt#147 adds it to docs but I don't think that's going to be that effective. We might want to add a comment to the PR or something like that.