Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix truncating when already at the correct size #5253

Merged
merged 1 commit into from
Jul 18, 2018
Merged

fix truncating when already at the correct size #5253

merged 1 commit into from
Jul 18, 2018

Conversation

schomatis
Copy link
Contributor

Fixes #4518.

(Taken from PR #4517.)

@schomatis schomatis requested a review from Kubuxu as a code owner July 18, 2018 13:56
@ghost ghost assigned schomatis Jul 18, 2018
@ghost ghost added the status/in-progress In progress label Jul 18, 2018
@schomatis
Copy link
Contributor Author

@whyrusleeping Need to get this merged to add the "truncate at same size" test in #5216 (comment).

Stebalien
Stebalien previously approved these changes Jul 18, 2018
@Stebalien Stebalien dismissed their stale review July 18, 2018 14:11

Not quite ready.

mfs/mfs_test.go Outdated
defer cancel()
ds, rt := setupRoot(ctx, t)

dir := rt.GetValue().(*Directory)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs fix for rebase.

fixes #4518

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
@schomatis
Copy link
Contributor Author

Rebased, thanks!

@Stebalien Stebalien added RFM and removed status/in-progress In progress labels Jul 18, 2018
@whyrusleeping whyrusleeping merged commit d74ec0d into ipfs:master Jul 18, 2018
@schomatis schomatis deleted the fix/dag-truncate/same-size branch July 18, 2018 15:52
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants