-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
pin update fixes #5265
pin update fixes #5265
Conversation
Stebalien
commented
Jul 20, 2018
- flush pins
- correctly print output
- add a sharness test
@Stebalien What issue/PR/doc would you recommend to learn about the pinning system architecture to better understand the |
Don't know. Looking at the code, it looks like pins are cached in-memory until the user calls |
There's some interesting logic down there.. |
Sounds reasonable. I can confirm this fixes some weird LGTM, minus the rebase, probably because I took to long to review this, sorry. |
will merge in 0.4.18 |
@Stebalien needs a rebase, sorry. |