Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

gx update deps #5268

Merged
merged 1 commit into from
Jul 24, 2018
Merged

gx update deps #5268

merged 1 commit into from
Jul 24, 2018

Conversation

Stebalien
Copy link
Member

@Stebalien Stebalien commented Jul 21, 2018

Updates:

  • go-net
  • go-text
  • dns
  • prometheus
  • protobuf

Dedups:

  • protobuf

Unblocks:

Part of:

@Stebalien Stebalien requested a review from Kubuxu as a code owner July 21, 2018 04:09
@ghost ghost assigned Stebalien Jul 21, 2018
@ghost ghost added the status/in-progress In progress label Jul 21, 2018
@Stebalien
Copy link
Member Author

I had to play some games to get prometheus working (especially with our version of protobuf). It would be nice to test this on a gateway before merging.

@Stebalien Stebalien force-pushed the gx/update-deps branch 5 times, most recently from 0967c6a to b8a7928 Compare July 23, 2018 17:24
Updates:

* go-net
* go-text
* dns
* prometheus
* protobuf (golang, not gogo)

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
@Stebalien Stebalien added need/review Needs a review and removed status/in-progress In progress labels Jul 23, 2018
@Stebalien
Copy link
Member Author

@lgierth this patch updates prometheus. Can we test it on a gateway?

Also, is #4132 still valid?

@Stebalien Stebalien requested a review from a user July 23, 2018 20:10
@Stebalien
Copy link
Member Author

Alternative to #5269. We can also do both but this patch also deduplicates the protobuf packages.

@whyrusleeping whyrusleeping merged commit eb59a62 into master Jul 24, 2018
@whyrusleeping
Copy link
Member

yolo

@whyrusleeping whyrusleeping deleted the gx/update-deps branch July 24, 2018 00:17
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
need/review Needs a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants