switch to go 1.11 #5483
Merged
switch to go 1.11 #5483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Stebalien
added
the
status/blocked
|
Blocked on CI updates (and possibly a gx release) |
|
Ok, ipfs-inactive/jenkins#126 was deployed, so I rebuilt this branch, but it's failing. https://ci.ipfs.team/blue/organizations/jenkins/IPFS%2Fgo-ipfs/detail/PR-5483/3/pipeline/14 |
|
We need to cut a new gx-go release. I'm going to try to merge some fixes first. |
|
Any progress on this? |
Go 1.11 changes the output of `go fmt` slightly so we either need to all *downgrade* or *upgrade*. Let's upgrade. License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
Stebalien
removed
the
status/blocked
|
So, I released a new GX but this is still failing saying that go 1.11 is not available. Does anything else need to be done to get it working? |
|
You need to add a build to dists built with go1.11: Then set the hash in https://github.com/ipfs/go-ipfs/pull/5483/files#diff-31a09fc8a6f12712273987524eccb1faR3 |
License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
|
Ah, thanks! |
magik6k
approved these changes
Oct 9, 2018
Kubuxu
approved these changes
Oct 9, 2018
Voker57
pushed a commit
to Voker57/go-ipfs
that referenced
this pull request
Oct 10, 2018
switch to go 1.11
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go 1.11 changes the output of
go fmtslightly so we either need toall downgrade or upgrade. Let's upgrade.