clarification the document of --resolve flag in name.publish #5651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
reviewed
Oct 29, 2018
core/commands/name/publish.go
Outdated
| @@ -73,7 +73,7 @@ Alternatively, publish an <ipfs-path> using a valid PeerID (as listed by | |||
| cmdkit.StringArg(ipfsPathOptionName, true, false, "ipfs path of the object to be published.").EnableStdin(), | |||
| }, | |||
| Options: []cmdkit.Option{ | |||
| cmdkit.BoolOption(resolveOptionName, "Resolve given path before publishing.").WithDefault(true), | |||
| cmdkit.BoolOption(resolveOptionName, "Check the given path whether can be resolved before publishing. <<default>>").WithDefault(true), | |||
There was a problem hiding this comment.
"Check if the given path can be resolved before publishing"
kjzz
force-pushed
the
fix/reslove-note
branch
from
9c46a15 to
95351fd
Compare
|
Update. |
magik6k
reviewed
Oct 31, 2018
core/commands/name/publish.go
Outdated
| @@ -73,7 +73,7 @@ Alternatively, publish an <ipfs-path> using a valid PeerID (as listed by | |||
| cmdkit.StringArg(ipfsPathOptionName, true, false, "ipfs path of the object to be published.").EnableStdin(), | |||
| }, | |||
| Options: []cmdkit.Option{ | |||
| cmdkit.BoolOption(resolveOptionName, "Resolve given path before publishing.").WithDefault(true), | |||
| cmdkit.BoolOption(resolveOptionName, "Check if the given path can be resolved before publishing. <<default>>").WithDefault(true), | |||
There was a problem hiding this comment.
Don't need the '<>', since the cmds lib appends this automatically
ghost
assigned 
License: MIT Signed-off-by: Kejie Zhang <601172892@qq.com>
License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
Stebalien
force-pushed
the
fix/reslove-note
branch
from
a2833b9 to
3c29855
Compare
Stebalien
approved these changes
Jan 24, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #5368
License: MIT
Signed-off-by: Kejie Zhang 601172892@qq.com