Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

commands/p2p: use new cmds lib #5672

Merged
merged 2 commits into from
Nov 2, 2018
Merged

Conversation

overbool
Copy link
Contributor

Refer: #5664

License: MIT
Signed-off-by: Overbool overbool.xu@gmail.com

@overbool overbool requested a review from Kubuxu as a code owner October 27, 2018 03:40
@overbool overbool force-pushed the refactor/commands/p2p branch from aa1c73e to 52154e9 Compare October 28, 2018 04:50
Copy link
Member

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 1 thing then LGTM

Copy link
Contributor

@kevina kevina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Stebalien Stebalien mentioned this pull request Oct 31, 2018
73 tasks
License: MIT
Signed-off-by: Overbool <overbool.xu@gmail.com>
License: MIT
Signed-off-by: Overbool <overbool.xu@gmail.com>
@Stebalien Stebalien force-pushed the refactor/commands/p2p branch from 0df1e9c to 488db7d Compare November 2, 2018 20:05
@ghost ghost assigned Stebalien Nov 2, 2018
@ghost ghost added the status/in-progress In progress label Nov 2, 2018
@Stebalien Stebalien merged commit 7864333 into ipfs:master Nov 2, 2018
@ghost ghost removed the status/in-progress In progress label Nov 2, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants