-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix build on Plan 9 #7690
fix build on Plan 9 #7690
Conversation
Thank you for submitting this PR!
Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution. |
the badger dep update merged to master, do you need a release of go-ds-badger for this to refer to? |
@willscott Yes, I need a new release of go-ds-badger. Thanks. |
I've updated go-ds-badger to the new version. This PR is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. @aschmahmann for second review / merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks 😄. Just added a question about a dependency change.
Also, it looks like the sharness tests are failing (perhaps due to the dependency change).
Fixes #7575
Fixes #7671
ipfs/go-ds-badger#100 should be merged before this PR. I'm using an indirect dependency as a workaround.(done)