Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix build on Plan 9 #7690

Merged
merged 1 commit into from
Sep 30, 2020
Merged

fix build on Plan 9 #7690

merged 1 commit into from
Sep 30, 2020

Conversation

fhs
Copy link
Contributor

@fhs fhs commented Sep 21, 2020

Fixes #7575
Fixes #7671

ipfs/go-ds-badger#100 should be merged before this PR. I'm using an indirect dependency as a workaround. (done)

@welcome
Copy link

welcome bot commented Sep 21, 2020

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

@willscott
Copy link
Contributor

the badger dep update merged to master, do you need a release of go-ds-badger for this to refer to?

@fhs
Copy link
Contributor Author

fhs commented Sep 23, 2020

the badger dep update merged to master, do you need a release of go-ds-badger for this to refer to?

@willscott Yes, I need a new release of go-ds-badger. Thanks.

@willscott
Copy link
Contributor

https://github.com/ipfs/go-ds-badger/releases/tag/v0.2.5

@fhs
Copy link
Contributor Author

fhs commented Sep 24, 2020

I've updated go-ds-badger to the new version. This PR is ready for review.

Copy link
Contributor

@willscott willscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. @aschmahmann for second review / merge

Copy link
Contributor

@aschmahmann aschmahmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks 😄. Just added a question about a dependency change.

Also, it looks like the sharness tests are failing (perhaps due to the dependency change).

@aschmahmann aschmahmann merged commit 8e6358a into ipfs:master Sep 30, 2020
@fhs fhs deleted the plan9-pr branch September 30, 2020 20:59
@aschmahmann aschmahmann mentioned this pull request Feb 18, 2021
73 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependabot wasn't able to update gopkg.in/cheggaaa/pb.v1 Add support for Plan 9
3 participants