Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Links are unnamed #56

Closed
hsanjuan opened this issue Feb 7, 2019 · 2 comments
Closed

Links are unnamed #56

hsanjuan opened this issue Feb 7, 2019 · 2 comments

Comments

@hsanjuan
Copy link
Contributor

hsanjuan commented Feb 7, 2019

It seems that all links are discovered and resolved without giving them a name.

This contradicts the "link name should be unique" rule as all links are named "" (? not sure this is a rule actually, just says that in the protobuf version).

Would seem sensible to use the path in the object as the link name. (so the link name should be the path that resolves it).

@Stebalien
Copy link
Member

See: ipfs/go-ipld-format#23

This is one of the many reasons @warpfork is working on https://github.com/ipld/go-ipld-prime (which will be renamed later). Basically, the "Link" structure is left over from the protobuf days (when all links had names/sizes).

@hsanjuan
Copy link
Contributor Author

hsanjuan commented Feb 7, 2019

This is a dup of #33 .

@hsanjuan hsanjuan closed this as completed Feb 7, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants