Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Support basic auth in REST API endpoints #121

Closed
hsanjuan opened this issue Jul 13, 2017 · 2 comments
Closed

Support basic auth in REST API endpoints #121

hsanjuan opened this issue Jul 13, 2017 · 2 comments
Assignees
@dgrisham
Labels
exp/novice Someone with a little familiarity can pick up kind/enhancement A net-new feature or improvement to an existing feature

Comments

@hsanjuan
Copy link
Collaborator

Password-protecting these might be useful. Must include integration from ipfs-cluster-ctl.
@hsanjuan hsanjuan added exp/novice Someone with a little familiarity can pick up kind/enhancement A net-new feature or improvement to an existing feature help wanted Seeking public contribution on this issue status/ready Ready to be worked labels Jul 13, 2017
@hsanjuan
Copy link
Collaborator Author

hsanjuan commented Aug 1, 2017 •
edited
Loading

Nice to have:

  • Cluster should support an array of { username: , password: } which are used by the API component to grant or deny access a map { "username": "pw" } works too.
  • Probably a boolean to activate it (disabled by default)
  • ipfs-cluster-ctl takes a -u flag for the username:password. (also allow to take from some env variable)
  • Introduce a .ipfs-cluster/ctl.json configuration file used by ipfs-cluster-ctl which allows to permanently configure:
    • Basic authorization user and password
    • ipfs-cluster host
    • https (and ignore)
    • Output format

@hsanjuan hsanjuan added status/in-progress In progress and removed status/ready Ready to be worked labels Aug 1, 2017
@dgrisham dgrisham removed the help wanted Seeking public contribution on this issue label Sep 11, 2017
@hsanjuan
Copy link
Collaborator Author

Implementation in #147

@hsanjuan hsanjuan added this to the All open issues with difficulty:medium or lower are fixed [Q4O1] milestone Oct 10, 2017
@hsanjuan hsanjuan mentioned this issue Oct 11, 2017
Merged
9 tasks
hsanjuan added a commit that referenced this issue Oct 16, 2017
@hsanjuan
Merge pull request #147 from ipfs/feat/api-basic-auth
6e40610 
Issue #121: BasicAuth REST API
@ghost ghost removed the status/in-progress In progress label Oct 16, 2017
@hsanjuan hsanjuan mentioned this issue Oct 17, 2017
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@dgrisham dgrisham

Labels
exp/novice Someone with a little familiarity can pick up kind/enhancement A net-new feature or improvement to an existing feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hsanjuan @dgrisham