Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Study how glibc ipfs docker image affects cluster docker images #154

Closed
hsanjuan opened this issue Sep 13, 2017 · 4 comments
Closed

Study how glibc ipfs docker image affects cluster docker images #154

hsanjuan opened this issue Sep 13, 2017 · 4 comments
Assignees
@hsanjuan
Labels
exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up

Comments

@hsanjuan
Copy link
Collaborator

See: ipfs/kubo#4219
@hsanjuan hsanjuan added exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue labels Sep 13, 2017
@ghost
Copy link

ghost commented Sep 13, 2017

Is ipfs-cluster something we should have in mind when making changes to go-ipfs's dockerfile? We try to keep it stable of course.

@ghost
Copy link

ghost commented Sep 13, 2017

Okay I see, you build the ipfs-cluster image from the ipfs/go-ipfs:release image -- after ipfs/kubo#4219 you just get a bare busybox image containing the go-ipfs binary, no package manager whatsoever.

@ghost
Copy link

ghost commented Sep 13, 2017

Maybe you can do a multistage dockerfile too -- first stage builds the ipfs-cluster binaries, second stage is built FROM ipfs/go-ipfs:release and COPYs the ipfs-cluster binaries from the first stage.

@hsanjuan
Copy link
Collaborator Author

We try to keep it stable of course.

yes yes, it has only broken for us in like every PR touching the dockerfile :)

Maybe you can do a multistage dockerfile too -- first stage builds the ipfs-cluster binaries, second stage is built FROM ipfs/go-ipfs:release and COPYs the ipfs-cluster binaries from the first stage.

There are permissions and ipfs-setup in the container which seems important and that's why we re-used . However I'm in the mind of simply not including ipfs in the ipfs-cluster container. Probably keep one that includes everything just for testing. But I'm not sure, I have to think a bit more about it.

@hsanjuan hsanjuan added this to the All open issues with difficulty:medium or lower are fixed [Q4O1] milestone Oct 10, 2017
@hsanjuan hsanjuan added kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up labels Oct 10, 2017
@hsanjuan hsanjuan mentioned this issue Oct 12, 2017
Merged
@hsanjuan hsanjuan mentioned this issue Oct 19, 2017
Closed
hsanjuan added a commit that referenced this issue Oct 20, 2017
@hsanjuan
Fix #154: Update Dockerfiles
4a66459 
After changes on how the final docker image for go-ipfs is generated,
our Dockerfiles failed to build.

The new version is inspired on go-ipfs Dockerfile. It takes advantage
of docker >= v17.06 which allows multi-stage Dockerfiles with
several FROM directives and COPY --from. This allows build freely on a
first stage, without thinking of cleaning up, and then just copy the
final artifacts to a second, minimal image.

The Dockerfile-test is similarly updated. Minor changes have been
applied to the entrypoints.

License: MIT
Signed-off-by: Hector Sanjuan <hector@protocol.ai>
@hsanjuan hsanjuan added the need/review Needs a review label Oct 20, 2017
@hsanjuan hsanjuan self-assigned this Oct 20, 2017
This was referenced Oct 20, 2017
Merged
Closed
hsanjuan added a commit that referenced this issue Oct 20, 2017
@hsanjuan
Issue #154: Use alpine for Dockerfile-test.
653a700 
Tests need bash for the moment.

License: MIT
Signed-off-by: Hector Sanjuan <hector@protocol.ai>
hsanjuan added a commit that referenced this issue Oct 20, 2017
@hsanjuan
Issue #154: Use alpine for Dockerfile-test.
2c1b293 
Tests need bash for the moment.

License: MIT
Signed-off-by: Hector Sanjuan <hector@protocol.ai>
hsanjuan added a commit that referenced this issue Oct 20, 2017
@hsanjuan
Issue #154: Remove tini from Dockerfile-test. Not used.
a38e912 
License: MIT
Signed-off-by: Hector Sanjuan <hector@protocol.ai>
hsanjuan added a commit that referenced this issue Oct 20, 2017
@hsanjuan
Issue #154: Add jq to testing Dockerfile
c75a369 
License: MIT
Signed-off-by: Hector Sanjuan <hector@protocol.ai>
hsanjuan added a commit that referenced this issue Oct 20, 2017
@hsanjuan
Merge pull request #185 from ipfs/fix/154-dockerfile
12c85ab 
Fix #154: Update Dockerfiles
@ghost ghost removed the need/review Needs a review label Oct 20, 2017
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@hsanjuan hsanjuan

Labels
exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hsanjuan