Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix #208: Set replication factor from loaded json #209

Merged
merged 1 commit into from
Oct 26, 2017
Merged

Fix #208: Set replication factor from loaded json #209

merged 1 commit into from
Oct 26, 2017

Conversation

hsanjuan
Copy link
Collaborator

License: MIT
Signed-off-by: Hector Sanjuan hector@protocol.ai

@hsanjuan
Fix #208: Set replication factor from loaded json
64dfaa2 
License: MIT
Signed-off-by: Hector Sanjuan <hector@protocol.ai>
@hsanjuan hsanjuan self-assigned this Oct 26, 2017
@hsanjuan hsanjuan requested a review from ZenGround0 October 26, 2017 14:16
@ghost ghost added the status/in-progress In progress label Oct 26, 2017
ZenGround0
ZenGround0 approved these changes Oct 26, 2017
View reviewed changes
Copy link
Collaborator

@ZenGround0 ZenGround0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 74.908% when pulling 64dfaa2 on fix/208-repl-factor into 3c48c35 on master.

@hsanjuan hsanjuan merged commit b392d28 into master Oct 26, 2017
@hsanjuan hsanjuan deleted the fix/208-repl-factor branch October 26, 2017 14:38
@ghost ghost removed the status/in-progress In progress label Oct 26, 2017
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ZenGround0 ZenGround0 ZenGround0 approved these changes

Assignees

@hsanjuan hsanjuan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hsanjuan @coveralls @ZenGround0