StateSync(): some improvements #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
lanzafame
approved these changes
May 25, 2018
cluster.go
Outdated
| @@ -728,29 +728,34 @@ func (c *Cluster) Join(addr ma.Multiaddr) error { | |||
| // StateSync syncs the consensus state to the Pin Tracker, ensuring | |||
| // that every Cid that should be tracked is tracked. It returns | |||
There was a problem hiding this comment.
Docstring needs updating.
This commit: * Does not collect and return changed items when doing StateSync (they are not used) * Removes the StateSync RPC method (no longer used) * Uses tracker.StatusAll() rather than requesting Status on each Cid (should be faster with upcoming pintracker) * Does not launch a go-routine to track every item. Track is an async operation. This likely causes 1000s goroutines to be started with no good reason. License: MIT Signed-off-by: Hector Sanjuan <code@hector.link>
Closed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit:
not used)
be faster with upcoming pintracker)
operation. This likely causes 1000s goroutines to be started with no good
reason.
License: MIT
Signed-off-by: Hector Sanjuan code@hector.link