Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Proxy-add does not work for larger files #495

Closed
13 of 25 tasks
hsanjuan opened this issue Jul 30, 2018 · 0 comments
Closed
13 of 25 tasks

Proxy-add does not work for larger files #495

hsanjuan opened this issue Jul 30, 2018 · 0 comments
Assignees
@hsanjuan
Labels
exp/intermediate Prior experience is likely helpful kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up

Comments

@hsanjuan
Copy link
Collaborator

hsanjuan commented Jul 30, 2018 •
edited
Loading

Pre-check

  • This is not a IPFS Cluster website content issue (file those here)
  • I read the troubleshooting section of the website and it did not help
  • I searched for similar issues in the repo without luck
  • All my peers are running the same cluster version
  • All my peers are configured using the same cluster secret

Basic information

  • Version information (mark as appropiate):
    • Master
    • Release candidate for next version
    • Latest stable version
    • An older version I should not be using
  • Type (mark as appropiate):
    • Bug
    • Feature request
    • Enhancement
  • Operating system (mark as appropiate):
    • Linux
    • macOS
    • Windows
    • Other: which?
  • Installation method (mark as appropiate):
    • Binaries from dist.ipfs.io
    • Built from sources
    • Docker
    • Snap
    • Other: which?

Description

Adding a file through the proxy fails for someone larger files (~MB). I think we are not correctly reading the full multipart body when adding, and likely just sending the first part in the proxied request.

This issue should be fixable (very easily) after the sharding branch is merged.
@hsanjuan hsanjuan added kind/bug A bug in existing code (including security flaws) exp/intermediate Prior experience is likely helpful status/blocked Unable to be worked further until needs are met P1 High: Likely tackled by core team if no one steps up labels Jul 30, 2018
@hsanjuan hsanjuan self-assigned this Aug 16, 2018
@hsanjuan hsanjuan added status/in-progress In progress and removed status/blocked Unable to be worked further until needs are met labels Aug 16, 2018
hsanjuan added a commit that referenced this issue Aug 16, 2018
@hsanjuan
Fix #495: Hijack proxy /add correctly.
d0d5ec0 
No more hacks around /add. This uses the local adder when hijacking /add.
It supports the parameters and works pretty well with the ipfs CLI, showing
progress and everything.

License: MIT
Signed-off-by: Hector Sanjuan <code@hector.link>
@hsanjuan hsanjuan mentioned this issue Aug 16, 2018
Merged
@hsanjuan hsanjuan mentioned this issue Aug 19, 2018
Closed
hsanjuan added a commit that referenced this issue Aug 20, 2018
@hsanjuan
Merge pull request #505 from ipfs/fix/495-proxy-add
63fa1ba 
Fix #495: Hijack proxy /add correctly. Disable keep-alives.
@ghost ghost removed the status/in-progress In progress label Aug 20, 2018
@hsanjuan hsanjuan mentioned this issue Aug 20, 2018
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@hsanjuan hsanjuan

Labels
exp/intermediate Prior experience is likely helpful kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hsanjuan