-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add make prcheck
#536
Labels
exp/novice
Someone with a little familiarity can pick up
kind/enhancement
A net-new feature or improvement to an existing feature
P3
Low: Not priority right now
Comments
also |
I believe we would need to run |
kishansagathiya
added a commit
to kishansagathiya/ipfs-cluster
that referenced
this issue
Sep 19, 2018
This commit adds a single make target that can run and check if I am ready to push my PR, i.e, `make prcheck` License: MIT Signed-off-by: Kishan Mohanbhai Sagathiya <kishansagathiya@gmail.com>
kishansagathiya
added a commit
to kishansagathiya/ipfs-cluster
that referenced
this issue
Sep 20, 2018
Fixes typo License: MIT Signed-off-by: Kishan Mohanbhai Sagathiya <kishansagathiya@gmail.com>
kishansagathiya
added a commit
to kishansagathiya/ipfs-cluster
that referenced
this issue
Sep 21, 2018
A test target should not modify the running system. Safest to run without test_sharness. Thus avoiding to install. License: MIT Signed-off-by: Kishan Mohanbhai Sagathiya <kishansagathiya@gmail.com>
hsanjuan
added a commit
that referenced
this issue
Sep 24, 2018
Issue #536 New make target for PR check
Closed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
exp/novice
Someone with a little familiarity can pick up
kind/enhancement
A net-new feature or improvement to an existing feature
P3
Low: Not priority right now
Pre-check
secret
Basic information
which?
which?
Description
Going through a Travis run I see that we do the following
It would be nice to have a single make target that I can run and check if I am ready to push my PR, say
make prcheck
The text was updated successfully, but these errors were encountered: