Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add make prcheck #536

Closed
13 of 25 tasks
kishansagathiya opened this issue Sep 12, 2018 · 2 comments
Closed
13 of 25 tasks

Add make prcheck #536

kishansagathiya opened this issue Sep 12, 2018 · 2 comments
Labels
exp/novice Someone with a little familiarity can pick up kind/enhancement A net-new feature or improvement to an existing feature P3 Low: Not priority right now

Comments

@kishansagathiya
Copy link
Contributor

Pre-check

  • This is not a IPFS Cluster website content issue (file those here)
  • I read the troubleshooting section of the website and it did not help
  • I searched for similar issues in the repo without luck
  • All my peers are running the same cluster version
  • All my peers are configured using the same cluster secret

Basic information

  • Version information (mark as appropiate):
    • Master
    • Release candidate for next version
    • Latest stable version
    • An older version I should not be using
  • Type (mark as appropiate):
    • Bug
    • Feature request
    • Enhancement
  • Operating system (mark as appropiate):
    • Linux
    • macOS
    • Windows
    • Other: which?
  • Installation method (mark as appropiate):
    • Binaries from dist.ipfs.io
    • Built from sources
    • Docker
    • Snap
    • Other: which?

Description

Going through a Travis run I see that we do the following

make deps
make check
make service
make ctl
make test

It would be nice to have a single make target that I can run and check if I am ready to push my PR, say make prcheck

@kishansagathiya kishansagathiya added kind/enhancement A net-new feature or improvement to an existing feature exp/novice Someone with a little familiarity can pick up P3 Low: Not priority right now labels Sep 12, 2018
@hsanjuan
Copy link
Collaborator

also make test_sharness. Sounds good to me if you want to take a stab at this.

@kishansagathiya
Copy link
Contributor Author

I believe we would need to run make install as well before make test_sharness, otherwise tests would be running for whatever the version that is currently installed.

kishansagathiya added a commit to kishansagathiya/ipfs-cluster that referenced this issue Sep 19, 2018
This commit adds a single make target that can run and check if I am
ready to push my PR, i.e, `make prcheck`

License: MIT
Signed-off-by: Kishan Mohanbhai Sagathiya <kishansagathiya@gmail.com>
kishansagathiya added a commit to kishansagathiya/ipfs-cluster that referenced this issue Sep 20, 2018
Fixes typo

License: MIT
Signed-off-by: Kishan Mohanbhai Sagathiya <kishansagathiya@gmail.com>
kishansagathiya added a commit to kishansagathiya/ipfs-cluster that referenced this issue Sep 21, 2018
A test target should not modify the running system. Safest to run
without test_sharness. Thus avoiding to install.

License: MIT
Signed-off-by: Kishan Mohanbhai Sagathiya <kishansagathiya@gmail.com>
hsanjuan added a commit that referenced this issue Sep 24, 2018
Issue #536 New make target for PR check
@hsanjuan hsanjuan mentioned this issue Sep 24, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
exp/novice Someone with a little familiarity can pick up kind/enhancement A net-new feature or improvement to an existing feature P3 Low: Not priority right now
Projects
None yet
Development

No branches or pull requests

2 participants