BlockAllocate rpc returns all peers when replication factor -1 but should return healthy ones only

[hsanjuan]

Pre-check

• This is not a IPFS Cluster website content issue (file those here)
• I read the troubleshooting section of the website and it did not help
• I searched for similar issues in the repo without luck
• All my peers are running the same cluster version
• All my peers are configured using the same cluster secret

Basic information

• Version information (mark as appropiate):
  • Master
  • Release candidate for next version
  • Latest stable version
  • An older version I should not be using
• Type (mark as appropiate):
  • Bug
  • Feature request
  • Enhancement

Description

The bug is here: https://github.com/ipfs/ipfs-cluster/blob/master/rpc_api.go#L205

When the adder allocates and replication factor is -1, we return all cluster peers. This ends up having the adder try to put blocks to peers which are down. We should use LatestMetrics instead from the monitor, with the "ping" metric type. And return the peerset extracted from those metrics (which are valid cluster peers).

[mike-ngu]

Hi guys!

Could you tell me please when are you planning to fix this bug and what I need to do to apply this updates?

If I not mistaken current version of IPFS is v0.4.17 and ipfs-cluster-service is version 0.5.0.
Does this mean that I have to wait until the next release to have this updates in my IPFS package?

[hsanjuan]

Hello. We will fix it for the next release. Hopefully this will come out in about two weeks.

[mike-ngu]

can't wait to test it

Thank you!

[hsanjuan]

Hello @mike-ngu , the a release candidate with this fix is available here: https://dist.ipfs.io/ipfs-cluster-service/

[mike-ngu]

Hello @hsanjuan,

Thank you for notification.

Just to clarify, to get last bug fixing I need to install ipfs-cluster-service package with version v0.6.0-rc1 ?

[hsanjuan]

yes, correct