Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix: snaps for tags #565

Merged
merged 1 commit into from
Oct 2, 2018
Merged

Fix: snaps for tags #565

merged 1 commit into from
Oct 2, 2018

Conversation

hsanjuan
Copy link
Collaborator

@hsanjuan hsanjuan commented Oct 1, 2018

It seems branch = master prevents building snaps for tags (?)

License: MIT
Signed-off-by: Hector Sanjuan code@hector.link

@hsanjuan
Fix: snaps for tags
52397f0 
It seems branch = master prevents building snaps for tags (?)

License: MIT
Signed-off-by: Hector Sanjuan <code@hector.link>
@hsanjuan hsanjuan self-assigned this Oct 1, 2018
@hsanjuan hsanjuan requested a review from lanzafame October 1, 2018 18:18
@ghost ghost added the status/in-progress In progress label Oct 1, 2018
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 65.221% when pulling 52397f0 on fix/snaps-again2 into 12e7695 on master.

@hsanjuan hsanjuan mentioned this pull request Oct 1, 2018
Closed
25 tasks
@lanzafame
Copy link
Contributor

@hsanjuan I have noticed that the continuous-integration/jenkins/branch has been stuck as 'Expected -- Waiting for status to be reported' on a few PRs now. Looking at Jenkins, it appears that the fix/snaps-again2 branch isn't on the branches page. I am not sure how to retrigger it.

@hsanjuan
Copy link
Collaborator Author

hsanjuan commented Oct 2, 2018

@lanzafame , from irc:

16:18:55 <@hsanjuan> Hector victorbjelkholm: lately I'm seeing quite a few " continuous-integration/jenkins/branch Expected — Waiting for status to be reported" . It seems that branch builds are sometimes not created. Have you seen this somewhere else?
16:21:35 <@victorbjelkholm> Victor Bjelkholm (On Vacation) hsanjuan: yeah, happens when you push a branch and create a PR right after, as creating a PR exits the branch job

@hsanjuan
Copy link
Collaborator Author

hsanjuan commented Oct 2, 2018

I have unchecked that jenkins branch builds as "required".

@hsanjuan hsanjuan merged commit 89aaabd into master Oct 2, 2018
@hsanjuan hsanjuan deleted the fix/snaps-again2 branch October 2, 2018 10:09
@ghost ghost removed the status/in-progress In progress label Oct 2, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@lanzafame lanzafame lanzafame approved these changes

Assignees

@hsanjuan hsanjuan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hsanjuan @coveralls @lanzafame