Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Allow ipfs-cluster-ctl to access files #579

Merged
merged 1 commit into from
Oct 16, 2018

Conversation

brianmcmichael
Copy link
Contributor

In the snap-installed distribution, calls like ipfs-cluster-ctl add myfile.txt fail with error Error: open myfile.txt: permission denied due to strict confinement to files in the /snap folder. Modifying confinement to classic will allow access to files elsewhere on the system.

@GitCop
Copy link

GitCop commented Oct 16, 2018

There were the following issues with your Pull Request

  • Commit: 293fb67
  • Invalid signoff. Commit message must end with
    License: MIT
    Signed-off-by:

Code contribution guidelines for IPFS Cluster are available at https://cluster.ipfs.io/developer/contribute/#code-contribution-guidelines


This message was auto-generated by https://gitcop.com

@hsanjuan
Copy link
Collaborator

Thanks @brianmcmichael! Any chance you can make @GitCop happy by modifying the commit message as indicated above?

@hsanjuan hsanjuan mentioned this pull request Oct 16, 2018
In the snap-installed distribution, calls like `ipfs-cluster-ctl add myfile.txt` fail with error `Error: open myfile.txt: permission denied` due to strict confinement to files in the /snap folder. Modifying confinement to `classic` will allow access to files elsewhere on the system.

License: MIT
Signed-off-by: brianmcmichael <brian@brianmcmichael.com>
@brianmcmichael
Copy link
Contributor Author

Try that, sorry about that!

@hsanjuan hsanjuan merged commit d29e993 into ipfs-cluster:master Oct 16, 2018
@coveralls
Copy link

coveralls commented Oct 17, 2018

Coverage Status

Coverage decreased (-0.02%) to 65.323% when pulling a1132b7 on brianmcmichael:patch-1 into f65349e on ipfs:master.

@hsanjuan
Copy link
Collaborator

It seems snap store automatically rejects snaps with classic confinement.

I made a request https://forum.snapcraft.io/t/classic-confinement-request-for-the-ipfs-cluster-snap/8056

@hsanjuan
Copy link
Collaborator

@brianmcmichael mind jumping on that thread and arguing your case?

@brianmcmichael
Copy link
Contributor Author

I left a comment. I'll keep an eye on it.

If it's accepted this will also require a change to the documentation where the installation invocation will be snap install ipfs-cluster --edge --classic

It's a common pattern though, used by apps that require arbitary file system access like Atom, VS Code, and Intellij

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants