config: Fix confusing errors #642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The JSON parsing of the config could error, but we skipped error checking and use Validate() at the end. This caused that maybe some JSON parsing errors where logged but the final error when validating the configuration came from somewhere different, creating very confusing error messages for the user. This changes this, along with removing hardcoded section lists. This also removes a Sharder component section because, AFAIK, it was a left over from the sharding branch and in the end there is no separate sharding component that needs a config. License: MIT Signed-off-by: Hector Sanjuan <code@hector.link>
ghost
added
the
Closed
In practice, we allowed this already, because parsing failed but Validate() succeeded. License: MIT Signed-off-by: Hector Sanjuan <code@hector.link>
|
Hmm I need to fix a small quirk with this |
They should not be interpreted as 0, since that may overwrite defaults which are not 0. We simply need to do nothing. License: MIT Signed-off-by: Hector Sanjuan <code@hector.link>
hsanjuan
force-pushed
the
fix/config-errors
branch
from
325e31d to
7f30a5e
Compare
|
I'll merge this since I'm going to release. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JSON parsing of the config could error, but we skipped error checking and
use Validate() at the end. This caused that maybe some JSON parsing errors
where logged but the final error when validating the configuration came from
somewhere different, creating very confusing error messages for the user.
This changes this, along with removing hardcoded section lists. This also
removes a Sharder component section because, AFAIK, it was a left over
from the sharding branch and in the end there is no separate sharding
component that needs a config.
License: MIT
Signed-off-by: Hector Sanjuan code@hector.link