Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

sharness: Fix test typo causing an empty grep #643

Merged
merged 3 commits into from
Jan 14, 2019
Merged

Conversation

hsanjuan
Copy link
Collaborator

The ipfs container does not have jq in it. We need to run jq outside of it. This was logged when tests run, but the test did not fail.

License: MIT
Signed-off-by: Hector Sanjuan <code@hector.link>
@hsanjuan hsanjuan self-assigned this Jan 11, 2019
@ghost ghost added the status/in-progress In progress label Jan 11, 2019
@hsanjuan hsanjuan mentioned this pull request Jan 11, 2019
@coveralls
Copy link

coveralls commented Jan 11, 2019

Coverage Status

Coverage decreased (-0.03%) to 65.604% when pulling 9685c08 on fix/sharness-jq-typo into b93aad1 on master.

kishansagathiya and others added 2 commits January 14, 2019 13:01
Fix the pid extraction in test.

Co-Authored-By: hsanjuan <hsanjuan@users.noreply.github.com>

License: MIT
Signed-off-by: Hector Sanjuan <code@hector.link>
License: MIT
Signed-off-by: Hector Sanjuan <code@hector.link>
@hsanjuan hsanjuan force-pushed the fix/sharness-jq-typo branch from 807f459 to 9685c08 Compare January 14, 2019 12:01
@ipfs-cluster ipfs-cluster deleted a comment from GitCop Jan 14, 2019
@ipfs-cluster ipfs-cluster deleted a comment from GitCop Jan 14, 2019
@hsanjuan hsanjuan merged commit 04cd9a5 into master Jan 14, 2019
@hsanjuan hsanjuan deleted the fix/sharness-jq-typo branch January 14, 2019 13:50
@ghost ghost removed the status/in-progress In progress label Jan 14, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants