Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Testing: Add extra tests for Basic Authentication in "restapi" #645

Closed
2 tasks done
hsanjuan opened this issue Jan 11, 2019 · 2 comments
Closed
2 tasks done

Testing: Add extra tests for Basic Authentication in "restapi" #645

hsanjuan opened this issue Jan 11, 2019 · 2 comments
Assignees
@alekswn
Labels
kind/enhancement A net-new feature or improvement to an existing feature P1 High: Likely tackled by core team if no one steps up
Milestone
Q2 2019 Easy

Comments

@hsanjuan
Copy link
Collaborator

hsanjuan commented Jan 11, 2019 •
edited
Loading

Basic information

  • Type (mark as appropiate):
    • Enhancement

Description

Apparently we only test the basic authentication support in sharness. This is not ideal. We should test it in the restapi module (with different request methods, and paths, and with different users, valid and invalid ones).
@hsanjuan hsanjuan added kind/enhancement A net-new feature or improvement to an existing feature help wanted Seeking public contribution on this issue status/ready Ready to be worked P1 High: Likely tackled by core team if no one steps up labels Jan 11, 2019
@hsanjuan hsanjuan added this to the Q1 2019 Easy milestone Jan 11, 2019
@alekswn
Copy link
Collaborator

alekswn commented Feb 26, 2019

Hi,
I'm new to the project but very excited to contribute.
Have dug a bit in restapi_test.go file, and I'm sure I can do this.
I'll take this issue if nobody minded.

@kishansagathiya
Copy link
Contributor

kishansagathiya commented Feb 26, 2019 •
edited
Loading

@alekswn sure, go ahead and take it. Once you raise a PR you would be assigned this automatically.

@hsanjuan hsanjuan added status/in-progress In progress and removed help wanted Seeking public contribution on this issue status/ready Ready to be worked labels Feb 26, 2019
alekswn added a commit to alekswn/ipfs-cluster that referenced this issue Mar 1, 2019
@alekswn
fix ipfs-cluster#645: Refactoring of testAPI and testHTTPSAPI()
f5ee1a7 
License: MIT
Signed-off-by: Alexey Novikov <alexey@novikov.io>
alekswn added a commit to alekswn/ipfs-cluster that referenced this issue Mar 1, 2019
@alekswn
fix ipfs-cluster#645: testAPIwithBasicAuth()
ca74af7 
License: MIT
Signed-off-by: Alexey Novikov <alexey@novikov.io>
alekswn added a commit to alekswn/ipfs-cluster that referenced this issue Mar 1, 2019
@alekswn
fix ipfs-cluster#645: make TestBasicAuth() pass
f3694e6 
License: MIT
Signed-off-by: Alexey Novikov <alexey@novikov.io>
alekswn added a commit to alekswn/ipfs-cluster that referenced this issue Mar 2, 2019
@alekswn
fix ipfs-cluster#645: testcases added for Basic Auth in rest API
f1ff3af 
License: MIT
Signed-off-by: Alexey Novikov <alexey@novikov.io>
alekswn added a commit to alekswn/ipfs-cluster that referenced this issue Mar 2, 2019
@alekswn
fix ipfs-cluster#645: go fmt
0bb8754 
License: MIT
Signed-off-by: Alexey Novikov <alexey@novikov.io>
@ghost ghost assigned alekswn Mar 2, 2019
alekswn added a commit to alekswn/ipfs-cluster that referenced this issue Mar 2, 2019
@alekswn
fix ipfs-cluster#645: golint
b4cb46f 
License: MIT
Signed-off-by: Alexey Novikov <alexey@novikov.io>
alekswn added a commit to alekswn/ipfs-cluster that referenced this issue Mar 2, 2019
@alekswn
fix ipfs-cluster#645: fix error messages
d1c0729 
License: MIT
Signed-off-by: Alexey Novikov <alexey@novikov.io>
hsanjuan added a commit that referenced this issue Mar 3, 2019
@hsanjuan
Merge pull request #694 from alekswn/fix/645-BasicAuthTest
6a37c5c 
fix #645: Basic Authentication test in REST API
@ghost ghost removed the status/in-progress In progress label Mar 3, 2019
@hsanjuan hsanjuan mentioned this issue Mar 3, 2019
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@alekswn alekswn

Labels
kind/enhancement A net-new feature or improvement to an existing feature P1 High: Likely tackled by core team if no one steps up
Projects
None yet
Milestone
Q2 2019 Easy
Development

No branches or pull requests
3 participants
@hsanjuan @alekswn @kishansagathiya