Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Rename observations Config fields #671

Merged
merged 1 commit into from
Feb 15, 2019
Merged

Rename observations Config fields #671

merged 1 commit into from
Feb 15, 2019

Conversation

roignpar
Copy link
Collaborator

  • StatsReportingInterval -> ReportingInterval
  • TracingSamplingProb -> SamplingProb
  • TracingServiceName -> ServiceName

This is needed for #663

@roignpar
Rename observations Config fields
bac23c0 
* StatsReportingInterval -> ReportingInterval
* TracingSamplingProb -> SamplingProb
* TracingServiceName -> ServiceName

License: MIT
Signed-off-by: Robert Ignat <robert.ignat91@gmail.com>
@ghost ghost assigned roignpar Feb 13, 2019
@ghost ghost added the status/in-progress In progress label Feb 13, 2019
@hsanjuan
Copy link
Collaborator

Let's wait for tests and @lanzafame . We'll merge tomorrow

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.009%) to 65.82% when pulling bac23c0 on roignpar:rename_observations_config into b4f0eb3 on ipfs:master.

@hsanjuan hsanjuan merged commit d49884b into ipfs-cluster:master Feb 15, 2019
@ghost ghost removed the status/in-progress In progress label Feb 15, 2019
@roignpar roignpar deleted the rename_observations_config branch February 15, 2019 14:51
@hsanjuan hsanjuan mentioned this pull request Feb 18, 2019
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@hsanjuan hsanjuan hsanjuan approved these changes

@lanzafame lanzafame lanzafame approved these changes

Assignees

@roignpar roignpar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@roignpar @hsanjuan @coveralls @lanzafame