Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix/UUID pkg #708

Merged
merged 2 commits into from
Mar 9, 2019
Merged

Fix/UUID pkg #708

merged 2 commits into from
Mar 9, 2019

Conversation

lanzafame
Copy link
Contributor

Depends on #706.

@lanzafame lanzafame requested a review from hsanjuan March 8, 2019 02:19
@ghost ghost assigned lanzafame Mar 8, 2019
@ghost ghost added the status/in-progress In progress label Mar 8, 2019
@hsanjuan
Copy link
Collaborator

hsanjuan commented Mar 8, 2019

I would appreciate if you make a PR against the existing PR (or commit directly to it)

@lanzafame lanzafame changed the base branch from master to gomod March 9, 2019 04:03
lanzafame added 2 commits March 9, 2019 14:05
@lanzafame
change uuid pkg to github.com/google/uuid
50e5fb8 
License: MIT
Signed-off-by: Adrian Lanzafame <adrianlanzafame92@gmail.com>
@lanzafame
tidy go.mod
0998f52 
License: MIT
Signed-off-by: Adrian Lanzafame <adrianlanzafame92@gmail.com>
@lanzafame
Copy link
Contributor Author

@hsanjuan I pointed this at the gomod branch and I also removed the github.com/gopherjs/gopherjs dependency.

@lanzafame lanzafame mentioned this pull request Mar 9, 2019
Merged
@hsanjuan hsanjuan merged commit 55569f9 into gomod Mar 9, 2019
@ghost ghost removed the status/in-progress In progress label Mar 9, 2019
@hsanjuan hsanjuan deleted the fix/uuid-pkg branch March 9, 2019 21:22
@hsanjuan
Copy link
Collaborator

hsanjuan commented Mar 9, 2019

Thanks!

This was referenced Mar 9, 2019
Closed
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@hsanjuan hsanjuan hsanjuan approved these changes

Assignees

@lanzafame lanzafame

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lanzafame @hsanjuan