Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Sharness broken after https://github.com/chriscool/sharness/pull/90 #797

Closed
hsanjuan opened this issue May 27, 2019 · 2 comments · Fixed by #892
Closed

Sharness broken after https://github.com/chriscool/sharness/pull/90 #797

hsanjuan opened this issue May 27, 2019 · 2 comments · Fixed by #892
Assignees
@kishansagathiya
Labels
exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked

Comments

@hsanjuan
Copy link
Collaborator

felipec/sharness#90 breaks our tests because sharness cannot find the right functions.sh file (we need to set some env variables I think).

In the meantime I'm reverting to using a previous version of the lib.
@hsanjuan hsanjuan added kind/bug A bug in existing code (including security flaws) help wanted Seeking public contribution on this issue exp/novice Someone with a little familiarity can pick up status/ready Ready to be worked P1 High: Likely tackled by core team if no one steps up labels May 27, 2019
hsanjuan added a commit that referenced this issue May 27, 2019
@hsanjuan
Fix: sharness: do not use latest master
e664f2b 
latest master breaks (see #797)
hsanjuan added a commit that referenced this issue May 27, 2019
@hsanjuan
Fix: sharness: do not use latest master
d5cef9d 
latest master breaks (see #797)
@chriscool
Copy link

Sorry I didn't know that you used the master branch directly. On other IPFS related projects I don't think the master branch is used.

It shouldn't be very difficult to fix though. Did you try to set SHARNESS_TEST_SRCDIR to the directory where one can find sharness.sh?

If you don't have time to take a look, I might try to fix this in the next few days.

@hsanjuan
Copy link
Collaborator Author

hsanjuan commented Jun 5, 2019

@chriscool no worries, it's my fault for pulling master blindly for this. The proper fix is not hard and not urgent. But thanks!

@kishansagathiya kishansagathiya mentioned this issue Aug 19, 2019
Merged
@hsanjuan hsanjuan mentioned this issue Sep 6, 2019
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@kishansagathiya kishansagathiya

Labels
exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use the updated sharness library ipfs-cluster/ipfs-cluster
3 participants
@chriscool @hsanjuan @kishansagathiya