Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

"Sync/Status/Recover" operations should not broadcast to peers with remote pins #935

Closed
hsanjuan opened this issue Oct 8, 2019 · 0 comments · Fixed by #947
Closed

"Sync/Status/Recover" operations should not broadcast to peers with remote pins #935

hsanjuan opened this issue Oct 8, 2019 · 0 comments · Fixed by #947
Labels
exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked

Comments

@hsanjuan
Copy link
Collaborator

hsanjuan commented Oct 8, 2019

Describe the feature you are proposing

Right now these operations do a full broadcast to all peers even though they know that for certain pins, the item is only allocated to some of them so only those can take any action.

Additional context

Double-check what happens when calling those and pins are remote (whether it effectively becomes a noop).
@hsanjuan hsanjuan added kind/enhancement A net-new feature or improvement to an existing feature help wanted Seeking public contribution on this issue exp/novice Someone with a little familiarity can pick up status/ready Ready to be worked P2 Medium: Good to have, but can wait until someone steps up labels Oct 8, 2019
@kishansagathiya kishansagathiya mentioned this issue Oct 29, 2019
Merged
@hsanjuan hsanjuan mentioned this issue Nov 13, 2019
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked
Projects
None yet
Milestone
No milestone
1 participant
@hsanjuan