Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

ipfs-cluster-service: allow to select logging facilities and level #938

Open
hsanjuan opened this issue Oct 12, 2019 · 2 comments
Open

ipfs-cluster-service: allow to select logging facilities and level #938

hsanjuan opened this issue Oct 12, 2019 · 2 comments
Labels
exp/wizard Extensive knowledge (implications, ramifications) required help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature status/ready Ready to be worked

Comments

@hsanjuan
Copy link
Collaborator

Describe the feature you are proposing

Rework --loglevel flag so that specific component logging can be selected. Or leave this flag as it is and provide new flags/ways of selecting logging components. Allow the user to inspect the existing logging facilities and the default log-level that they are using.

Additional context

Current approach is pretty much log all or nothing.

@hsanjuan hsanjuan added kind/enhancement A net-new feature or improvement to an existing feature help wanted Seeking public contribution on this issue exp/wizard Extensive knowledge (implications, ramifications) required status/ready Ready to be worked labels Oct 12, 2019
@kishansagathiya
Copy link
Contributor

Allow the user to inspect the existing logging facilities and the default log-level that they are using.

log.json with identifier to logleve map in ~/.ipfs-cluster will give user ability to customize logs for multiple cluster runs

To weed out unwanted for just current run a --skip-log-fac could be provided.

@hsanjuan
Copy link
Collaborator Author

Thinking more of exposing /health/logs or the sort. Not going to handle another configuration file for this.

There are two parts:

  • Letting ipfs-cluster-service set the right log levels and facilities on boot (flags can also be mapped to env vars)
  • Allowing to inspect/change at runtime.

Can be done in separate PRs.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
exp/wizard Extensive knowledge (implications, ramifications) required help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature status/ready Ready to be worked
Projects
None yet
Development

No branches or pull requests

2 participants