Skip to content
This repository has been archived by the owner on Mar 10, 2020. It is now read-only.

Add bl module to package.json dependencies #853

Closed
0xall opened this issue Sep 10, 2018 · 2 comments
Closed

Add bl module to package.json dependencies #853

0xall opened this issue Sep 10, 2018 · 2 comments

Comments

@0xall
Copy link
Contributor

0xall commented Sep 10, 2018

Hi, I'm using ipfs-api (and I don't use js-ipfs) in my electron project.

bl is used in https://github.com/ipfs/js-ipfs-api/blob/master/src/files/cat.js#L6

but in package.json, it is not in dependencies, so error occurs when executing my electron program builded. (Of course, if I add "bl": "^2.0.1" module to package.json dependencies in my project, it works)

Can you add it to package.json?

@alanshaw
Copy link
Contributor

Thanks for reporting @seungwon-kang - would you mind sending a PR to fix?

0xall added a commit to 0xall/js-ipfs-api that referenced this issue Sep 10, 2018
@0xall
Copy link
Contributor Author

0xall commented Sep 10, 2018

Of course! I sended PR :)

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

No branches or pull requests

2 participants